(Translated by https://www.hiragana.jp/)
⚓ T340626 Update SearchVue for IP Masking
Page MenuHomePhabricator

Update SearchVue for IP Masking
Closed, ResolvedPublic

Description

IP Masking means that we create a temporary account for any user that's editing without being logged in. More details on how temporary account work here, and more details on what to look for when adapting an extension to handle temporary accounts is here

A quick search for relevant code in the SearchVue extension is here

We'll need to consider whether to change isAnon, and test everything to make sure it still works when logged in as a temp user or a regular user or not logged in at all.

To enable temporary accounts in your local dev env, add this to LocalSettings.php

$wgAutoCreateTempUser['enabled'] = true;

Event Timeline

Change 935769 had a related patch set uploaded (by Cparle; author: Cparle):

[mediawiki/extensions/SearchVue@master] IP masking update

https://gerrit.wikimedia.org/r/935769

The only change I've made here is to not show the "tutorial" popup to temp users (same as anon users) as they can't edit their preferences

AFAICS the only other thing to consider here is analytics. If we change nothing further then temp users will be considered the same as regular users in our analytics - so in our dashboard when you choose to filter by anonymous users (in the filters on the left) this won't include temp users. This seems reasonable enough to me, but we could v easily change it so that temp users counted in the "anonymous" category too if we wanted ... or also we could have temp users in their own category (which would be more work). @AUgolnikova-WMF any thoughts?

@Cparle Thanks Cormac. As long as we know what the numbers mean, I don't think we need to spend additional effort on adjusting anything in the analytics for search

Ok great, then I think the patch above is all we need

Change 935769 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] IP masking update

https://gerrit.wikimedia.org/r/935769

QA notes: temporary accounts are enabled on beta dewiki

SearchVue is not enabled on beta dewiki. Since temp users will have the same workflows as anon users, probably, it's ok for now to leave the betalabs setup as it is. I'll ask about adding more betalabs wikis. Temp users need to be tested across wikis anyway.

@Etonkovidova ... so, is this as "done" as it's possible to get for now?

@Etonkovidova ... so, is this as "done" as it's possible to get for now?

I'd prefer to leave the task in Verify on Production; the task was not tested in beta (IP masking is not enabled on wikis with SearchVue), so a quick check after deployment to production should be done.

@Etonkovidova ... so, is this as "done" as it's possible to get for now?

I'd prefer to leave the task in Verify on Production; the task was not tested in beta (IP masking is not enabled on wikis with SearchVue), so a quick check after deployment to production should be done.

On second thought, I agree with @Cparle - given the IP-masking timeline, it makes sense to resolve this task. SearchVue for IP Masking will be checked in production as part of checking T341839: [QA task] IP masking - temp users testing in production.