Create GlobalBlockingConnectionProvider
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Feb 13 2024, 12:22 PM

Description

A service is needed that allows callers to get a database connection to the virtual-globalblocking database domain. This will replace the methods in the GlobalBlocking.php static utility class.

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T357399 here

Details

	Subject	Repo	Branch	Lines +/-
	Create GlobalBlockingConnectionProvider	mediawiki/extensions/GlobalBlocking	master	+87 -28

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	None	T326816 Update features for temporary accounts
Open	None	T355286 [Epic] Globally blocking a temporary account should prevent further account creations
Open	None	T19929 CentralAuth account locks should trigger global autoblocks
Duplicate	None	T340275 Allow GlobalBlocking to block temporary accounts
Open	Skizzerz	T17294 Allow blocking of global accounts
Open	Dreamy_Jazz	T356990 GlobalBlocking extension has poor test coverage
Open	None	T358777 Rename messages with the '-new' suffix to remove this suffix
Open	None	T358776 Remove old versions of GlobalBlocking i18n messages
Open	None	T358773 Remove the global accounts block configuration flag
Open	None	T356924 Deploy global account blocks to WMF wikis
Open	Dreamy_Jazz	T356926 Add support to block global accounts using the globalblock API
Open	Dreamy_Jazz	T356929 Allow SpecialRemoveGlobalBlock to remove a global block on an account
Resolved	Dreamy_Jazz	T356931 Support modifying the status of global blocks on accounts using Special:GlobalBlockStatus
Open	Dreamy_Jazz	T356932 Allow Special:GlobalBlockList to show global blocks for accounts
Resolved	Dreamy_Jazz	T356934 Allow a user to perform global blocks on accounts using Special:GlobalBlock
Open	Dreamy_Jazz	T356935 The 'globalblocks' API should support listing global blocks for accounts
Resolved	Dreamy_Jazz	T356936 Update GlobalBlocking services to support global block on accounts
Resolved	Dreamy_Jazz	T358150 Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts
Resolved	Dreamy_Jazz	T358157 Update the GlobalBlockManager service to support global blocks on accounts
Resolved	Dreamy_Jazz	T358155 Update GlobalBlockLookup service to support global blocks on accounts
Resolved	Dreamy_Jazz	T356876 Add a column to store central ID in globalblocks and global_block_whitelist tables
Resolved	Marostegui	T356987 Add gb_target_central_id to the globalblocks table on the centralauth DB
Resolved	Marostegui	T356988 Add gbw_target_central_id to global_block_whitelist table on WMF wikis
Resolved	Dreamy_Jazz	T356922 Deprecate unnecessary GlobalBlocking hooks
Resolved	Dreamy_Jazz	T359091 Create GlobalBlockLocalStatusManager service
Resolved	Dreamy_Jazz	T358865 Use non-legacy log parameters for log entries for global blocking and unblocking
Resolved	Dreamy_Jazz	T358725 Update the GlobalBlockingLinkBuilder service for global account blocks
Resolved	Dreamy_Jazz	T356923 Create a configuration value to control whether global account blocks are enabled
Resolved	Tchanders	T360516 Periodically remove orphaned global_block_whitelist entries
Resolved	Dreamy_Jazz	T360621 Test and make improvements to the fixGlobalBlockWhitelist.php script
Open	None	T366386 Update GlobalBlockingHooks to support global account blocks
Open	None	T350075 Migrate raw SQL building in conditions to expression builder in WMF-deployed extensions
Resolved	Dreamy_Jazz	T350972 Use expression builder instead of raw SQL in GlobalBlocking
Resolved	Dreamy_Jazz	T357385 Refactor the GlobalBlocking utility class into services
Resolved	Dreamy_Jazz	T357399 Create GlobalBlockingConnectionProvider
Resolved	Dreamy_Jazz	T357506 Create GlobalBlockLocalStatusLookup service
Resolved	Dreamy_Jazz	T357675 Create GlobalBlockLookup service
Resolved	Dreamy_Jazz	T357925 Create the GlobalBlockManager service

Event Timeline

Dreamy_Jazz created this task.Feb 13 2024, 12:22 PM

Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)).

Dreamy_Jazz set the point value for this task to 1.

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.

Change 1002970 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Create GlobalBlockingConnectionProvider

https://gerrit.wikimedia.org/r/1002970

gerritbot added a project: Patch-For-Review.Feb 13 2024, 12:39 PM

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.Feb 13 2024, 12:52 PM

Dreamy_Jazz claimed this task.Feb 14 2024, 11:11 AM

Change 1002970 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Create GlobalBlockingConnectionProvider

https://gerrit.wikimedia.org/r/1002970

Suggested steps for QA:

Install GlobalBlocking, if not already installed
Log into an account with steward rights if you have MediaWiki-extensions-CentralAuth installed or an account that has the globalblock right (you can give this right to admins using $wgGroupPermissions['sysop']['globalblock'] = true; in LocalSettings.php)
Use Special:GlobalBlock to make a global block on an IP address
Load Special:GlobalBlockList
Verify that the global block you applied appears in the list of global blocks.

These steps were designed to verify that no changes to the on-wiki interface have been made by this patch (as this ticket and patch refactored existing code without changing functionality). You may wish to test that nothing changed compared to running these steps on a wiki which does not have this change applied.

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2024, 11:30 PM

Dreamy_Jazz mentioned this in T357443: Create GlobalBlockingBlockPurger service.Feb 14 2024, 11:42 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 15 2024, 2:01 AM

Dreamy_Jazz mentioned this in T357506: Create GlobalBlockLocalStatusLookup service.Feb 16 2024, 5:16 PM

@Dreamy_Jazz Nothing changed as previously and has the same functions as seen in screenshots and .webm. This will be moved to Done. Thanks for all your work!

Status: ✅PASS
Environment: Local: 1.42.0-alpha (f3389a3)23:25, 16 February 2024; GlobalBlocking: commit 093123a6b8b990b96061450874cfac5235d347e8 & bffe54f3cbc809dd36389ea26e9ca05f631b3414
OS: macOS Sonoma 14.2.1
Browser: Chrome 121
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog#