(Translated by https://www.hiragana.jp/)
⚓ T366175 [Generalised error] Invalid query parameter
Page MenuHomePhabricator
Create Task
Maniphest T366175

[Generalised error] Invalid query parameter
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Acceptance criteria:

  • Current messages it will replace: Invalid value for _fields or property for GET /items GET /properties and GET /statements endpoints
  • HTTP status code: 400
  • Error code: invalid-query-parameter
  • Error message: Invalid query parameter: '{parameter}'
  • Context: "parameter": "{matching query parameter in the OpenAPI spec}"

Details

SubjectRepoBranchLines +/-
REST: Generalise 'invalid-query-parameter' errormediawiki/extensions/Wikibasemaster+75 -67
Customize query in gerrit

Related Objects

Event Timeline

Ifrahkhanyaree_WMDE created this task.May 29 2024, 1:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 29 2024, 1:14 PM
Ifrahkhanyaree_WMDE moved this task from Backlog to Polished on the Wikibase Product Platform Team WPP board.Jun 5 2024, 11:02 AM
Ifrahkhanyaree_WMDE renamed this task from [Generalised error] Incorrect query parameter to [Generalised error] Invalid query parameter.Jun 5 2024, 11:05 AM
Ifrahkhanyaree_WMDE updated the task description. (Show Details)
WMDE-leszek updated the task description. (Show Details)Jun 6 2024, 10:30 AM
WMDE-leszek updated the task description. (Show Details)Jun 6 2024, 10:33 AM
WMDE-leszek set the point value for this task to 3.Jun 6 2024, 10:35 AM
Ifrahkhanyaree_WMDE moved this task from Polished to Ready for planning on the Wikibase Product Platform Team WPP board.Jun 7 2024, 9:20 AM
Ifrahkhanyaree_WMDE moved this task from Ready for planning to Sprint 22 on the Wikibase Product Platform Team WPP board.Jun 11 2024, 9:55 AM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 22); removed Wikibase Product Platform Team WPP.
Jakob_WMDE subscribed.EditedJun 12 2024, 1:06 PM

Task breakdown notes:

  • respond with the new errors for _fields (item), _fields (property)
    • adjust the corresponding deserializing request validators to throw the new kinds of UseCaseErrors
    • adjust the examples in the spec
  • respond with the new error for property (statements list)
    • adjust the examples in the spec
    • this currently reuses the same validator as property ID path parameters but now needs a separate validator since the error is different
Silvan_WMDE claimed this task.Jun 19 2024, 7:34 AM
Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 22) board.
gerritbot added a comment.Jun 20 2024, 8:05 AM

Change #1047908 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Generalise 'invalid-query-parameter' error

https://gerrit.wikimedia.org/r/1047908

gerritbot added a project: Patch-For-Review.Jun 20 2024, 8:05 AM
Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 22) board.Jun 20 2024, 9:22 AM
gerritbot added a comment.Jun 22 2024, 2:01 PM

Change #1047908 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Generalise 'invalid-query-parameter' error

https://gerrit.wikimedia.org/r/1047908

Maintenance_bot removed a project: Patch-For-Review.Jun 22 2024, 2:30 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Jun 22 2024, 3:00 PM
Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 22) board.Jun 23 2024, 12:55 PM
Ifrahkhanyaree_WMDE closed this task as Resolved.Jun 25 2024, 10:08 AM
Ifrahkhanyaree_WMDE moved this task from Backlog to Done on the Wikibase REST API (WPP) board.Jun 25 2024, 1:13 PM
Ollie.Shotton_WMDE mentioned this in T368398: [MAIN] REST API v1 CHECKLIST.Jun 26 2024, 5:13 PM
Ifrahkhanyaree_WMDE added a parent task: T368398: [MAIN] REST API v1 CHECKLIST.Jul 17 2024, 9:56 AM
Ifrahkhanyaree_WMDE removed a parent task: T368398: [MAIN] REST API v1 CHECKLIST.Jul 18 2024, 9:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits