In T362518#9856834, @BPirkle wrote:

If Growth is done with the old nodejs-based image-suggestion-api, then it can go away now. Nikki and I worked on that ages ago, and it was superseded by something else. I switched to other work, so I can't say what production may be using these days, but I'm confident it isn't that.

Filled T366534: Archive mediawiki/services/image-suggestion-api to archive the repository instead; it is no longer necessary.

Based on the discussion above, let's go with MediaWikiConfig{Reader/Provider}. I find that to be more appropriate, as MediaWikiConfigReader only interacts with MediaWikiConfigProvider (check done via instanceof), so it makes sense for both classes to have similar names.

This block testwiki rollout.

Putting this on sprint board for (internal) visibility.

In T362518#9854617, @Tgr wrote:

In T362518#9854325, @Clement_Goubert wrote:

@dancy @Tgr docker-registry.wikimedia.org/wikimedia/mediawiki-services-image-suggestion-api needs to be rebuilt through this CR

No idea who owns that service these days; maybe @Urbanecm_WMF would know.

Since I fixed the reported issue, moving this to sprint and QA.

I tried making a couple of changes using the Special:EditGrowthConfig form at test2.wikipedia.org (which does not have Add Image or section images enabled), and I did not manage to remove the image-related configuration. Maybe this was a bug in EditGrowthConfig that we fixed before? Or maybe I'm not trying to reproduce the bug correctly.

Thanks for filling the task! This comes from the Add an Image feature, which is exposed in two places: Special:Homepage and Wikipedia's mobile phone app. Those two places are independent on each other, which means that Special:Homepage might not offer Add Image, but the mobile app might (or vice versa). The mobile app does use Growth's APIs for identifying the recommendations, and for informing us about decision made by the app users (this avoids the same recommendation being made both in Homepage and the app).

Thanks all! Waiting on the Spanish translation, then I'll add all of them at the same time. CC @IZapico-WMF, whenever you have time for this :)

In T365150#9842994, @Trizek-WMF wrote:

How will this scale, by the way? When we release CC to all wikis, we can't ask all of them to translate this page name individually, right?

Thanks @Michael! This makes sense. We should be able to fix this within our next sprint (starting tomorrow).

I agree that option 3 is the way to go – given the self-containedness of the usage, it makes sense to go for that option. Thanks @Michael for listing the options!

In T363815#9836304, @Etonkovidova wrote:

@Urbanecm_WMF - should the schema be added to the logstash Growth event validation dashboard ?

Thanks for taking a look at this, @Michael!

Done.

Started all three.

Good points @Aklapper! In the light of your comment, I think it does make sense to link (and monitor) https://www.mediawiki.org/wiki/Extension_talk:CommunityConfiguration instead, and possibly rephrase the comment.

Unfortunately, adding those two options is more problematic than it looks like. I filled T365612: Growth features: Add Levelling up related configuration for that problem. The list of infoboxes settings is currently ignored as well, I filled that problem as T365606: List of infobox templates in Special:CommunityConfiguration/GrowthSuggestedEdits is ignored.

There are two possible solutions here, I'll call them option 1 and option 2.

Hi @BTullis, thanks for the feedback! Should be fixed now.